LT-22203: punct only line; multiple punct; rare no morph#405
Merged
Conversation
Change-Id: Ib92c66d6a7db544086f1413e59f04eaaffa1f536
jasonleenaylor
approved these changes
Jul 25, 2025
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
Sorry, xslt takes me a while to review. It makes my brain hurt.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AndyBlack)
Collaborator
Author
|
Yes, it can be challenging. I wish these changes did not make it even harder with so much actually being the same, just in a different location. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes three issues in XLingPaper interlinear export. The fixes are all in the xml2XLingPapCommonConcatMorphemes.xsl file. The diff may be a bit hard to read since it looks like a lot of changes, but it's a case of having to create some "choose/when" items to fix them so a lot of code which stays the same is now in a different location.
The three issues are:
<xsl:value-of select="normalize-space(.)"/>
<xsl:when test="name()='morph'">
As mentioned, there are two new test cases to check for these issues. The existing nszEnglishWords test case needed to be updated because it, too, had cases fixed by number 1.
This change is